Repository navigation
feat(python): add ATACCAMA to OssieVendor - #629
Conversation
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
No open issues 🎉
What changed in this PR
Registers ATACCAMA as a well-known vendor across the Python model and core specification examples so converters can resolve the vendor name consistently.
Changes:
- Added
ATACCAMAto theOssieVendorPython enum. - Updated spec example lists (
spec.yaml,ossie-schema.json) to includeATACCAMA. - Extended the spec documentation table (
spec.md) withATACCAMA.
| File | Description |
|---|---|
| python/src/ossie/models.py | Adds ATACCAMA to the well-known vendor enum used by the Python models. |
| core-spec/spec.yaml | Updates vendor name examples to include ATACCAMA. |
| core-spec/spec.md | Adds ATACCAMA to the documented list of well-known vendor examples. |
| core-spec/ossie-schema.json | Updates JSON schema vendor examples to include ATACCAMA. |
Review effort: Lite
christianeu-db
left a comment
There was a problem hiding this comment.
fyi: in #617, we're aiming to remove specific vendor examples from the core spec into an extensions folder. this means that new vendors can register as a known-constant without the usual 7 day DISCUSS period on the mailing list before merging.
If you scope the change to just models.py, I can fold your vendor registration into 617 and get this merged today
|
Thank you for your first contribution to Apache Ossie (incubating)! A committer will review your PR. In the meantime, please ensure:
No ICLA is required to contribute. If you are elected as a committer in the future, you will need an Individual Contributor License Agreement (ICLA) on file with the ASF. Questions? Ask in the PR comments or join us on Slack. We appreciate your contribution! |
@christianeu-db Yes that would be great, thank you. Is there something you need from me for this? |
@rostislavosvald-ataccama just scope the PR down to the models.py change and revert the rest. I'll add | |
The Ataccama converter in apache/ossie-converters tags its custom extensions with the ATACCAMA vendor name. Adding it to OssieVendor lets the converter use the enum instead of a bare string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
e5d22fb to
0c46e79
Compare
@christianeu-db Updated. |
Add the ATACCAMA token to the known-vendor table, per apache#629. Co-authored-by: Isaac <no-reply@databricks.com>
Bring in apache#596 (compliance portability fixtures), apache#618 (reject duplicate keys on load), and apache#629 (ATACCAMA vendor) from main. The only conflict was the import block of validation/validate.py, where this branch adds `difflib` plus the `Expression` dataclass/iterator imports and apache#618 adds `importlib.util` for the shared `_loading.py` bootstrap; resolved by keeping the union. apache#618's loader refactor merged cleanly onto the expression-iterator refactor, and apache#629's OssieVendor enum entry is complementary to this branch's vendors.md ATACCAMA row. Verified against validation-ci.yml: duplicate-key tests (59), validation pytest (268), python model tests (266), generator --check in sync, and all five example validations pass. Co-authored-by: Isaac <no-reply@databricks.com>
The Ataccama converter in apache/ossie-converters tags its custom extensions with the ATACCAMA vendor name, which needs to be available on OssieVendor before the converter can resolve it against this package.
Summary
This PR adds
ATACCAMAamong known vendors to the python models and to the specification examples. We are in process of introducing Ataccama convertor, which will expose its custom extension.Related Issues
None
Checklist
Specification
core-spec/and follow the existing structureOntology
N/A
Converters
Convertor PR will be created soon, however there is a light dependency on the model change.
Validation
N/A
Documentation
N/A: some vendors are mentioned in the docs, but there doesn't seem to be a need to enumerate all
Examples
examples/are added or updated for any new spec constructs (no new constructs)Tests
pytest/ CI green)Compliance
NOTICEand/orLICENSEhave been updated per ASF policy (no such code)