Repository navigation
test(compliance): add portability rungs M4-M6 and the FILTER (WHERE) form of M3 - #631
Open
MrBlack1995 wants to merge 5 commits into
Open
MrBlack1995 wants to merge 5 commits into
MrBlack1995 wants to merge 5 commits into
Conversation
One dataset with YEAR and DATE_TRUNC fields and an AVG(DATEDIFF(...)) metric, using the part-first DATEDIFF(part, start, end) order from expression_language.md. Adds one construct on top of the baseline. Co-authored-by: Isaac <no-reply@databricks.com>
expression_language.md makes the aggregate FILTER (WHERE ...) clause REQUIRED. Two variants (qualified and bare) express the same filtered aggregate as the existing CASE WHEN fixtures, so a difference between the two forms isolates handling of the clause itself. Co-authored-by: Isaac <no-reply@databricks.com>
Two datasets joined by a declared relationship and one model-scoped metric that aggregates across the join (SUM over one dataset divided by a COUNT DISTINCT over the other), referencing fields as dataset.field. Co-authored-by: Isaac <no-reply@databricks.com>
A model-scoped metric (avg_order_value) composed from two other model-scoped metrics referenced by name, per Metric Scoping in core-spec/spec.md. Co-authored-by: Isaac <no-reply@databricks.com>
Lists the M3 FILTER (WHERE ...) form and rungs M4-M6 in the README table, notes that M7 and M8 wait on the window ORDER BY NULL-placement default, and records that the fixtures live in this repository. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #596: the next portability rungs, one commit each, on top of the M0-M3 set. Each rung still adds one construct, so a difference in a converter's output localizes to it. Happy to drop or split any of these.
FILTER (WHERE ...)clause, whichexpression_language.mdmakes REQUIRED, qualified and barem3/m3_filter_clause_qualified.ossie.yaml,m3/m3_filter_clause_bare.ossie.yamlm4/m4_cross_dataset.ossie.yamlcore-spec/spec.md)m5/m5_metric_ref.ossie.yamlYEAR,DATE_TRUNC, part-firstDATEDIFF(part, start, end)m6/m6_date_scalars.ossie.yamlmanifest.yamlgets one entry per rung (and the two M3 variants), and the README table lists M0-M6.M7 and M8 (window and offset functions) are not included: they wait for the default NULL placement in window
ORDER BY(#587).Validation
validation/validate.pyon current main.Related Issues
Refs apache/ossie-converters#24 (portability measurement). Follows #596.