Repository navigation
docs(core-spec): correct Sigma CASE and NULLIF mappings - #660
Merged
Merged
Conversation
Sigma's If() is variadic, If(c1, v1, c2, v2, ..., else), with an optional else that defaults to Null, so a multi-branch CASE maps to it directly. Sigma also has a native NullIf(a, b). The Sigma converter uses both since apache/ossie-converters#12. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you for your first contribution to Apache Ossie (incubating)! A committer will review your PR. In the meantime, please ensure:
No ICLA is required to contribute. If you are elected as a committer in the future, you will need an Individual Contributor License Agreement (ICLA) on file with the ASF. Questions? Ask in the PR comments or join us on Slack. We appreciate your contribution! |
christianeu-db
approved these changes
Oct 29, 2026
christianeu-db
left a comment
christianeu-db
left a comment
Contributor
There was a problem hiding this comment.
Fine to merge. Although this fixes a core spec file, dialects are now opaque to the spec and are moving to extensions (#641).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two rows of the Sigma column in
core-spec/expression_language.md(Conditional Function Mapping) describe Sigma as less capable than it is:CASE WHEN...If(cond, t, f); no native multi-branchCASEIf(c1, v1, c2, v2, ..., else)(variadic; else is optional and defaults to Null)NULLIF(a, b)If(a = b, Null(), a)NullIf(a, b)Sigma documents both:
Iftakes condition/value pairs with an optional else, andNullIfis native. The Sigma converter has used both mappings since apache/ossie-converters#12, as suggested in that PR's review.Docs only; no spec semantics change.
Related Issues
Follows apache/ossie-converters#12 (fixes apache/ossie-converters#21).
Checklist
Specification
core-spec/and follow the existing structureConverters
Compliance