feat(python): add abort method to TableCommit for write rollback#612
Merged
JingsongLi merged 1 commit intoJul 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The Python binding is missing write rollback support. The core Rust TableCommit has an
abort()method and the C binding already exposes it viapaimon_table_commit_abort, but Python users have no way to clean up data files after a failed write. This PR addsabort()to the Python binding so callers can delete newly written files (data, changelog, index) before a commit is persisted.Brief change log
collect_and_validate_messageshelper, shared bycommit()andabort()PyTableCommit::abort()— calls through toTableCommit::abort(), best-effort file deletion (storage errors silently ignored)Tests
New abort-specific tests in
bindings/python/tests/test_write.py:test_abort_cleans_up_written_datatest_abort_empty_messages_nooptest_abort_non_message_raises_typeerrorTypeErrortest_abort_cross_table_messages_raisesValueError)test_abort_different_builder_same_table_raisesWriteBuilderrejected (ValueError)Run with:
cd bindings/python
.venv/bin/maturin develop --release
.venv/bin/python -m pytest tests/test_write.py -v -k abort
API and Format
New method on TableCommit:
table.new_write_builder().new_commit().abort(messages)
Documentation