[gs] Map gs.* config entries to fs.gs.* Hadoop config keys - #8936
Open
thswlsqls wants to merge 1 commit into
Open
[gs] Map gs.* config entries to fs.gs.* Hadoop config keys#8936thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
GSFileIO accepted both gs. and fs.gs. prefixed options but copied matching keys into the Hadoop configuration unchanged, so gs.* entries were silently ignored by the gcs-connector, which only reads fs.gs.* keys. Translate the accepted prefixes to fs.gs.* like S3FileIO and AzureFileIO do for their prefixes, and log the mapping at debug level without values. Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #8934
GSFileIO.configure()acceptsgs.andfs.gs.prefixes but passes keys to the Hadoop config unchanged, sogs.*options are silently ignored by the gcs-connector, which only readsfs.gs.*keys.fs.gs.*, matching siblingS3FileIO(s3.*->fs.s3a.*) andAzureFileIO(azure.*->fs.azure.*), and the upstream Flinkflink-gs-fs-hadoopConfigUtilsthis list was ported from.LOG.debugwith key names only, no values (precedent: [cosn] Log Hadoop config entries at debug level instead of warn #8554).Tests
GSFileIOTestcoveringgs.*key mapping,fs.gs.*key preservation, and unrelated keys being ignored.mvn -pl paimon-filesystems/paimon-gs-impl clean install— 3 tests passed (unit test only; no GCS backend available locally).