[core][spark] Support switching MAP storage layouts - #8941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, Paimon rejected changing the storage layout of an existing MAP
field between
defaultandshared-shredding.This restriction also prevented tables from gradually migrating their MAP
storage layout. After enabling shared shredding, a table can contain both old
default-layout MAP files and newly written shared-shredding files. Selected-key
pushdown must therefore be able to read both physical representations correctly.
This PR:
defaultandshared-shreddingwhile keeping the existing schema validation.default -> shared-shreddingshared-shredding -> defaultshared-shreddingshared-shredding metadata.
files.
MapColumnVector, preserving thesemantics of:
shared-shredding.current default layout.
Tests
Added and updated tests covering:
MapSharedShreddingUtils.buildPhysicalReadTypewith:missing keys, null values and null MAP rows.
rename.
INTtoBIGINT.layout.
generations.
The relevant common and core unit tests pass. The Spark E2E suite passes for
Spark 3.2, 3.3, 3.4, 3.5, 4.0 and 4.1 with both ORC and Parquet.