Skip to content

[core] Make SimpleCounter thread-safe #8942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Jul 30, 2026
+8 −6
Merged

[core] Make SimpleCounter thread-safe #8942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions paimon-core/src/main/java/org/apache/paimon/metrics/SimpleCounter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,18 @@

package org.apache.paimon.metrics;

import java.util.concurrent.atomic.AtomicLong;

/** A simple low-overhead {@link org.apache.paimon.metrics.Counter}. */
public class SimpleCounter implements Counter {

/** the current count. */
private long count;
private final AtomicLong count = new AtomicLong();

/** Increment the current count by 1. */
@Override
public void inc() {
count++;
count.incrementAndGet();
}

/**
Expand All @@ -37,13 +39,13 @@ public void inc() {
*/
@Override
public void inc(long n) {
count += n;
count.addAndGet(n);
}

/** Decrement the current count by 1. */
@Override
public void dec() {
count--;
count.decrementAndGet();
}

/**
Expand All @@ -53,7 +55,7 @@ public void dec() {
*/
@Override
public void dec(long n) {
count -= n;
count.addAndGet(-n);
}

/**
Expand All @@ -63,6 +65,6 @@ public void dec(long n) {
*/
@Override
public long getCount() {
return count;
return count.get();
}
}
Loading