[common] Read VECTOR fields from NestedRow - #9864
Merged
JingsongLi merged 1 commit intoSep 17, 2026
Merged
Conversation
NestedRow.getVector still threw the "Unsupported type: VectorType" stub left by apache#7204, so a primary-key table with a ROW<..., VECTOR> column failed at flush when the format writer read the nested row. Mirror BinaryRow.getVector / BinaryArray.getVector (apache#9773) with MemorySegmentUtils.readVectorData. Generated-by: Claude Code
JingsongLi
reviewed
Sep 17, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the NestedRow VECTOR decoding path. Aligning it with the existing BinaryRow vector decoding preserves nested vector projection semantics instead of treating nested values as generic bytes. The implementation and coverage look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #9861
NestedRow.getVectorstill threwIllegalArgumentException("Unsupported type: VectorType"), so a primary-key table with aROW<..., VECTOR>column failed at flush: the write buffer holdsBinaryRow, and the Parquet/Avro writer reads the nested row viaBinaryRow.getRow()→NestedRow.getVector().MemorySegmentUtils.readVectorData, mirroringBinaryRow.getVectorandBinaryArray.getVector;BinaryWriter.writeVectoralready writes the nested slot, so the layout is unchanged.BinaryArrayandNestedRow; [common] Support VECTOR elements in InternalArray accessors #9773 fixedBinaryArray; this fixes the last one.Tests
NestedRowTest#testNestedRowWithVector: round-trip ofROW<INT, ROW<INT, VECTOR(3, FLOAT)>>, null vector field,InternalRow.createFieldGetter(VECTOR), and the multi-segment case. Fails with the stub exception without the fix.mvn -pl paimon-common clean install(JDK 11): BUILD SUCCESS, 0 failures (checkstyle, spotless, enforcer included);NestedRowTest4/4.