[core] Add option to disable overflow exception in sum/product agg - #9874
Merged
Merged
Conversation
JingsongLi
reviewed
Sep 16, 2026
| return options.get( | ||
| key(FIELDS_PREFIX + "." + fieldName + ".sum.fail-on-overflow") | ||
| .booleanType() | ||
| .defaultValue(true)); |
Contributor
There was a problem hiding this comment.
Maybe default value should be false?
tsreaper
changed the title
JingsongLi
reviewed
Sep 17, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the overflow-option update. The default is now false, preserving the previous wrapping behavior unless strict overflow checking is explicitly enabled, and the option is passed through the production aggregation path. No additional blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#7992 & #7906 adds overflow detection in sum/product agg. If the result overflows, it will throw an exception.
However, some users don't care about overflows. This change will break their jobs without a way to recover.
This PR adds an option to disable the overflow exception.
Tests
FieldAggregatorTest