Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

import java.util.List;
import java.util.Map;
import java.util.Objects;

import static org.apache.paimon.utils.Preconditions.checkArgument;

Expand Down Expand Up @@ -106,7 +107,7 @@ public CreatePartitionsRequest(
&& partitionOptions.size() == partitionSpecs.size()),
"partitionOptions must be null or have the same size as partitionSpecs.");
checkArgument(
partitionOptions == null || !partitionOptions.contains(null),
partitionOptions == null || partitionOptions.stream().noneMatch(Objects::isNull),
"partitionOptions must not contain null maps.");
checkArgument(
partitionOptions == null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@

import org.junit.Test;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
Expand Down Expand Up @@ -530,6 +531,29 @@
assertFalse(PartitionStatistics.isKnown(parsedUnknown.fileCount()));
}

@Test
public void createPartitionsRequestAcceptsImmutablePartitionOptionsTest() {
Map<String, String> spec = Collections.singletonMap("dt", "20260916");
Map<String, String> options =
Collections.singletonMap("path", "oss://bucket/archive/dt=20260916");

// List.of answers contains(null) with a NullPointerException rather than false, so a
// caller handing over a valid immutable list must not be asked that question.
CreatePartitionsRequest request =
new CreatePartitionsRequest(List.of(spec), true, null, null, List.of(options));

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.12

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.12

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.12

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.12

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.13

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.13

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.13

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.13

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / E2E / Flink 1 and Spark interoperability

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / E2E / Flink 1 and Spark interoperability

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / E2E / Flink 1 and Spark interoperability

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / E2E / Flink 1 and Spark interoperability

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Licensing / Artifact licensing

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Licensing / Artifact licensing

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Licensing / Artifact licensing

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Licensing / Artifact licensing

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Flink 1 / Common

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Flink 1 / Common

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Flink 1 / Common

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Flink 1 / Common

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Full text / JDK 8

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Full text / JDK 8

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Full text / JDK 8

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Full text / JDK 8

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Core and integrations / JDK 8

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Core and integrations / JDK 8

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Core and integrations / JDK 8

cannot find symbol

Check failure on line 543 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Core and integrations / JDK 8

cannot find symbol
assertEquals(List.of(options), request.getPartitionOptions());

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.12

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.12

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.13

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.13

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / E2E / Flink 1 and Spark interoperability

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / E2E / Flink 1 and Spark interoperability

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Licensing / Artifact licensing

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Licensing / Artifact licensing

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Flink 1 / Common

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Flink 1 / Common

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Full text / JDK 8

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Full text / JDK 8

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Core and integrations / JDK 8

cannot find symbol

Check failure on line 544 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Core and integrations / JDK 8

cannot find symbol

List<Map<String, String>> withNullEntry = new ArrayList<>();
withNullEntry.add(null);
IllegalArgumentException failure =
assertThrows(
IllegalArgumentException.class,
() ->
new CreatePartitionsRequest(
List.of(spec), true, null, null, withNullEntry));

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.12

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.12

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.13

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Spark 3 / Scala 2.13

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / E2E / Flink 1 and Spark interoperability

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / E2E / Flink 1 and Spark interoperability

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Licensing / Artifact licensing

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Licensing / Artifact licensing

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Flink 1 / Common

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Flink 1 / Common

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Full text / JDK 8

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Full text / JDK 8

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Core and integrations / JDK 8

cannot find symbol

Check failure on line 553 in paimon-core/src/test/java/org/apache/paimon/rest/RESTApiJsonTest.java

View workflow job for this annotation

GitHub Actions / Java / Core and integrations / JDK 8

cannot find symbol
assertTrue(failure.getMessage().contains("partitionOptions must not contain null maps"));
}

@Test
public void dropPartitionsResponseParseTest() throws Exception {
Map<String, String> dropped = new HashMap<>();
Expand Down
Loading