[core] Unify manifest entry caching by physical block - #9919
Closed
leaves12138 wants to merge 1 commit into
Closed
leaves12138 wants to merge 1 commit into
leaves12138 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Unify the whole-manifest entry cache and the compressed Avro block cache used by sidecar-selected reads into one decoded-entry cache at physical block granularity.
This draft is based on current master, after #9897 and #9908. It contains only the Java cache changes and their tests/documentation, not the deferred Python writer integration from #9743.
Changes
ManifestEntryCachetoObjectsCache<BlockKey, ManifestEntry, ManifestEntrySegments>, keyed by manifest path, offset and encoded block length.SelectedBlockInput; keep the independent sidecar metadata-byte cache unchanged.Scope
No manifest/sidecar on-disk format or writer behavior changes. The
cache.manifest-sidecar.max-memoryoption and its default are unchanged. This is a draft for review of the cache design and implementation; production performance validation is not claimed here.Validation
git diff --checkpassed.mvn -pl paimon-core -am -DwildcardSuites=none -Dtest=Manifest*Test,ObjectsCacheTest,SegmentsCacheTest,DataPagedOutputSerializerTest,DataEvolutionBatchScanTest,CoreOptionsTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test.