Skip to content

issue with comments failing build #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjfanning merged 1 commit into from
Jul 10, 2026
Merged

issue with comments failing build #1149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions http-core/src/test/scala/org/apache/pekko/http/impl/engine/ws/WSClientAutobahnTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,7 @@ object WSClientAutobahnTest {
def updateReports(agent: String = Agent): Future[Unit] =
runToSingleText(updateReportsUri(agent)).map(_ => ())

/**
* Map from textual case ID (like 1.1.1) to IndexedCaseInfo
* @return
*/
// Map from textual case ID (like 1.1.1) to IndexedCaseInfo
def getCaseMap(): Future[Map[String, IndexedCaseInfo]] = {
val res =
getCaseCount().flatMap { count =>
Expand Down Expand Up @@ -176,11 +173,9 @@ object WSClientAutobahnTest {
def completionSignal[T]: Flow[T, T, Future[Done]] =
Flow[T].watchTermination((_, res) => res)

/**
* The autobahn tests define a weird API where every request must be a WebSocket request and
* they will send a single websocket message with the result. WebSocket everywhere? Strange,
* but somewhat consistent.
*/
// The autobahn tests define a weird API where every request must be a WebSocket request and
// they will send a single websocket message with the result. WebSocket everywhere? Strange,
// but somewhat consistent.
def runToSingleText(uri: Uri): Future[String] = {
val sink = Sink.head[Message]
runWs(uri, Flow.fromSinkAndSourceMat(sink, Source.maybe[Message])(Keep.left)).flatMap {
Expand All @@ -189,6 +184,7 @@ object WSClientAutobahnTest {
throw new IllegalStateException(s"unexpected element of type ${other.getClass}")
}
}

def runToSingleJsonValue[T: JsonReader](uri: Uri): Future[T] =
runToSingleText(uri).map(_.parseJson.convertTo[T])

Expand Down