+sbt Validate mima on pull request#320
Closed
He-Pin wants to merge 1 commit into
Closed
Conversation
pjfanning
reviewed
Sep 7, 2023
pjfanning
reviewed
Sep 7, 2023
Contributor
|
I don't think testing against multiple JDK's is necessary, doesn't MiMa analyze the raw bytecode by reading it in which case it doesn't matter what JDK its being run as (i.e. its just a standard program). |
He-Pin
force-pushed
the
mima
branch
2 times, most recently
from
6eea17f to
89432ed
Compare
Member
Author
|
Closing this PR as MiMa validation is now included in the validate-and-test.yml workflow (runs as part of the standard CI pipeline). This change is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #312