Skip to content

Make TcpConnectionSpec pull-mode reads deterministic #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
He-Pin merged 1 commit into from
Jul 11, 2026
+6 −2
Merged

Make TcpConnectionSpec pull-mode reads deterministic #3321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions actor-tests/src/test/scala/org/apache/pekko/io/TcpConnectionSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,15 +395,18 @@ class TcpConnectionSpec extends PekkoSpec("""
val maxBufferSize = 1 * 1024
val ts = "t" * maxBufferSize
val us = "u" * (maxBufferSize / 2)
val tsAndUs = ts ++ us

// send a batch that is bigger than the default buffer to make sure we don't recurse and
// send more than one Received messages
serverSideChannel.write(ByteBuffer.wrap((ts ++ us).getBytes("ASCII")))
serverSideChannel.write(ByteBuffer.wrap(tsAndUs.getBytes("ASCII"))) should ===(tsAndUs.length)
clientSelectionKey should be(selectedAs(OP_READ, remainingOrDefault))
connectionHandler.expectNoMessage(100.millis)

connectionActor ! ResumeReading
connectionHandler.expectMsgType[Received].data.decodeString("ASCII") should ===(ts)

clientSelectionKey should be(selectedAs(OP_READ, remainingOrDefault))
connectionHandler.expectNoMessage(100.millis)

connectionActor ! ResumeReading
Expand All @@ -412,7 +415,8 @@ class TcpConnectionSpec extends PekkoSpec("""
connectionHandler.expectNoMessage(100.millis)

val vs = "v" * (maxBufferSize / 2)
serverSideChannel.write(ByteBuffer.wrap(vs.getBytes("ASCII")))
serverSideChannel.write(ByteBuffer.wrap(vs.getBytes("ASCII"))) should ===(vs.length)
clientSelectionKey should be(selectedAs(OP_READ, remainingOrDefault))

connectionActor ! ResumeReading

Expand Down