Fix OutboundIdleShutdownSpec harmless quarantine setup#3322
Merged
Conversation
Motivation: OutboundIdleShutdownSpec still expects harmless quarantine events to propagate, but Pekko 2.0 changed the production default to off. The test therefore waits for an event that cannot be emitted. Modification: Enable propagate-harmless-quarantine-events explicitly for OutboundIdleShutdownSpec while leaving the production default and HarmlessQuarantineSpec unchanged. Result: The spec continues to cover legacy propagation, while HarmlessQuarantineSpec covers the default suppression behavior. Tests: - remote focused harmless echo test: passed 3 consecutive runs - OutboundIdleShutdownSpec and HarmlessQuarantineSpec: 10 tests passed - sbt checkCodeStyle: passed - sbt +headerCheckAll: passed - git diff --check: passed References: Refs apache#2430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pekko 2.0 changed
pekko.remote.artery.propagate-harmless-quarantine-eventsto default tooff, butOutboundIdleShutdownSpecstill expects a harmless quarantine to publishThisActorSystemQuarantinedEvent. The spec therefore waits for an event that the default configuration deliberately suppresses.Modification
Explicitly enable harmless quarantine event propagation for
OutboundIdleShutdownSpec.HarmlessQuarantineSpeccontinues to use the production default and cover the suppression behavior.Result
The two specs again cover both directions:
ThisActorSystemQuarantinedEventNo production configuration or runtime behavior changes.
References
Refs #2430