PHOENIX-7845 ReplicationLogGroup initialization resilience to standby cluster unavailability#2466
Open
tkhurana wants to merge 2 commits intoapache:PHOENIX-7562-feature-newfrom
Open
Conversation
… cluster unavailability
…eption - Replace RuntimeException wrapping in get() with UncheckedIOException to avoid misclassifying unrelated RuntimeExceptions with IOException causes - Bound peer shard manager creation with configurable timeout (default 10s) via CompletableFuture.get() to prevent blocking the disruptor handler thread on peer NN outage; TimeoutException triggers SAF degradation - Consolidate peer shard manager into a single lazy synchronized accessor on ReplicationLogGroup; remove per-component caching from forwarder - Cancel the in-flight future on timeout to release the ForkJoinPool thread - Add test for timeout-triggered SAF degradation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReplicationLogGroup.init()to individual mode consumers (SyncModeImpl,SyncAndForwardModeImpl,ReplicationLogDiscoveryForwarder)updateModeOnFailure()pathReplicationLogGroup.get()to throwIOExceptioninstead ofRuntimeException, so callers inIndexRegionObserverget proper error classification (not misclassified asIndexBuildingFailureException)createStandbyLog()/createFallbackLog()with singlecreateReplicationLog(shardManager)factoryTest plan
testInitDegradesToSafWhenPeerUnavailable— peer unavailable at startup → SAF mode, writes succeedtestInitFailsWhenLocalUnavailable— local FS unavailable → init fails with IOExceptiontestForwarderRetriesPeerCreation— forwarder retries peer shard manager on next round after initial failureReplicationLogGroupTesttests passReplicationLogDiscoveryForwarderTesttests passReplicationLogTesttests pass