[fix][client] Fix UnAckedMessageRedeliveryTracker to skip cancelled timeouts#26043
Open
Dream95 wants to merge 1 commit into
Open
[fix][client] Fix UnAckedMessageRedeliveryTracker to skip cancelled timeouts#26043Dream95 wants to merge 1 commit into
Dream95 wants to merge 1 commit into
Conversation
…imeouts Signed-off-by: Dream95 <zhou_8621@163.com>
lhotari
approved these changes
Jun 17, 2026
void-ptr974
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
UnAckedMessageTracker already guards its periodic ack-timeout TimerTask with Timeout.isCancelled() to avoid executing after cancellation. UnAckedMessageRedeliveryTracker had the same scheduling pattern but lacked this guard, so a cancelled timeout callback could still run and trigger unnecessary redelivery/rescheduling work.
Modifications
Add the t.isCancelled() fast-path return to UnAckedMessageRedeliveryTracker TimerTask.run(...).
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes