Skip to content

[fix][client] Fix UnAckedMessageRedeliveryTracker to skip cancelled timeouts#26043

Open
Dream95 wants to merge 1 commit into
apache:masterfrom
Dream95:fix_ack-timeout-cancelled
Open

[fix][client] Fix UnAckedMessageRedeliveryTracker to skip cancelled timeouts#26043
Dream95 wants to merge 1 commit into
apache:masterfrom
Dream95:fix_ack-timeout-cancelled

Conversation

@Dream95

@Dream95 Dream95 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Motivation

UnAckedMessageTracker already guards its periodic ack-timeout TimerTask with Timeout.isCancelled() to avoid executing after cancellation. UnAckedMessageRedeliveryTracker had the same scheduling pattern but lacked this guard, so a cancelled timeout callback could still run and trigger unnecessary redelivery/rescheduling work.

Modifications

Add the t.isCancelled() fast-path return to UnAckedMessageRedeliveryTracker TimerTask.run(...).

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

…imeouts

Signed-off-by: Dream95 <zhou_8621@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants