[fix][fn] Return descriptive errors for unknown JSON properties - #26441
Open
zgzyq wants to merge 1 commit into
Open
[fix][fn] Return descriptive errors for unknown JSON properties#26441zgzyq wants to merge 1 commit into
zgzyq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18253
Motivation
The Functions Worker APIs return a generic HTTP 400 response when a multipart JSON configuration contains an unknown property. Pulsar already has an
UnrecognizedPropertyExceptionMapperthat produces a descriptive error, but the Functions Worker resource configurations do not register it.Modifications
UnrecognizedPropertyExceptionMapperfor the Functions Worker V2 APIs.UnrecognizedPropertyExceptionMapperfor the Functions Worker V3 APIs.Verifying this change
This change added tests and can be verified as follows:
./gradlew :pulsar-functions:pulsar-functions-worker:test --tests "org.apache.pulsar.functions.worker.rest.ResourcesTest" -PtestRetryCount=0./gradlew :pulsar-functions:pulsar-functions-worker:checkstyleMain :pulsar-functions:pulsar-functions-worker:checkstyleTestDoes this pull request potentially affect one of the following parts: