SOLR-18214: Default configset clone base to _default when omitted#4368
Open
openworld-maker wants to merge 1 commit intoapache:mainfrom
Open
SOLR-18214: Default configset clone base to _default when omitted#4368openworld-maker wants to merge 1 commit intoapache:mainfrom
openworld-maker wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes SOLR-18214 by making
baseConfigSetoptional in the v2 configset clone/create API path.When
baseConfigSetis omitted, the API now uses_default(matching documented behavior and v1 mapping semantics).Changes
CloneConfigSet, resolve omitted/emptyrequestBody.baseConfigSettoCloneConfigsetRequestBody.DEFAULT_CONFIGSET.CloneConfigSetAPITest.testMissingBaseConfigSetDefaultsToDefaultConfigsetTestConfigSetsAPI.testV2CreateWithoutBaseConfigsetUsesDefaultValidation
Ran in Docker (JDK 21):
:solr:core:test --tests 'org.apache.solr.cloud.TestConfigSetsAPI' --tests 'org.apache.solr.handler.configsets.*':solr:core:spotlessCheckResult:
BUILD SUCCESSFUL(56 tests, 1 skipped for selected test scope).