SOLR-17995: Deprecate "core URL" SolrStream constructors - #4830
Open
gerlowskija wants to merge 4 commits into
Open
SOLR-17995: Deprecate "core URL" SolrStream constructors#4830gerlowskija wants to merge 4 commits into
gerlowskija wants to merge 4 commits into
Conversation
Solr is moving towards using "base URLs" rather than "core URLs" where possible. Standardizing on base URLs avoids baking v1 specifics into many code-paths. It also makes our code easier to understand: historically we're not very good at documenting which URL pattern is expected by which method, so standardizing brings a lot of readability benefits. This commit deprecates several SolrStream constructors that use "core URLs".
epugh
reviewed
Aug 31, 2026
Contributor
Author
|
FYI @dsmiley - I believe you asked about consolidating some of these ctors on a QT-removal PR... |
dsmiley
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to some recent additions, SolrStream currently has 4 different constructors in order to support taking in either "base" URLs or "core" URLs. This is a bit ugly.
Solution
This PR streamlines this by deprecating the "core URL" constructors and switching usages over to using the "base URL" constructors instead. The "core URLs" aren't removed entirely, though this can be done (on
mainonly) in a subsequent PR.Tests
Existing tests continue to pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.