Review and tidy solr/modules/s3-repository code - #4838
Open
epugh wants to merge 1 commit into
Open
Conversation
Split out from apache#4743 into a per-module PR to make review easier. Contains only the tidy-up changes to solr/modules/s3-repository (dead config-getter removal, unnecessary throws removal, JUnit assertEquals argument-order fixes, javadoc/comment fixes). No behavior changes; S3OutputStream's buffer/flush logic is untouched (comment-only fix).
| } | ||
| } | ||
|
|
||
| static int getIntConfig(NamedList<?> config, String property) { |
Contributor
There was a problem hiding this comment.
Why these methods were removed ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split out from #4743 into smaller, per-module PRs to make review easier. This PR contains only the tidy-up changes to
solr/modules/s3-repository.Solution
Leverage IntelliJ warnings (dead config-getter removal, unnecessary
throwsremoval, JUnitassertEqualsargument-order fixes, javadoc/comment fixes). No behavior changes —S3OutputStream's buffer/flush/multipart-upload logic is untouched (comment-only fix).Tests
existing
Relates to #4743