[SPARK-59406][UI] Fix UI display on weird custom log names - #58699
Draft
holdenk wants to merge 2 commits into
Draft
[SPARK-59406][UI] Fix UI display on weird custom log names#58699holdenk wants to merge 2 commits into
holdenk wants to merge 2 commits into
Conversation
Custom log names and URLs can contain markup characters, so escape them when rendering the logs column and quote the href attribute. Only http(s) and relative URLs are rendered as links; anything else is shown as plain text. Co-authored-by: Cursor <cursoragent@cursor.com>
…s intentional The class covers the ASCII range browsers strip when parsing URLs, so no-control-regex does not apply here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Better handling for custom log names and URLs
Why are the changes needed?
Custom log names can be weird, so let's validate that they're displayable before we display them.
Does this PR introduce any user-facing change?
Invalid log URLs will be replaced with "#"
How was this patch tested?
New unit tests
Was this patch authored or co-authored using generative AI tooling?
Claude and cursor