Skip to content

[MINOR][SQL] Hoist loop-invariant left row out of the AS-OF join inner scan #58879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-mollitor-db wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MINOR][SQL] Hoist loop-invariant left row out of the AS-OF join inner scan #58879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeAsOfJoinExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,11 @@ private[joins] class SortMergeAsOfJoinScanner(
var bestMatch: InternalRow = null
val iter = rightGroupBuffer.generateIterator()

// `leftRow` is fixed for this scan, so bind it once; only the right side changes per row.
joinedRow.withLeft(leftRow)
while (iter.hasNext) {
val rightRow = iter.next()
joinedRow.withLeft(leftRow).withRight(rightRow)
joinedRow.withRight(rightRow)

val asOfSatisfied = boundAsOfCond.eval(joinedRow)
if (asOfSatisfied != null && asOfSatisfied.asInstanceOf[Boolean]) {
Expand Down Expand Up @@ -418,9 +420,11 @@ private[joins] class SortMergeAsOfJoinScanner(
var bestDistance: Any = null
val iter = rightGroupBuffer.generateIterator()

// `leftRow` is fixed for this scan, so bind it once; only the right side changes per row.
joinedRow.withLeft(leftRow)
while (iter.hasNext) {
val rightRow = iter.next()
joinedRow.withLeft(leftRow).withRight(rightRow)
joinedRow.withRight(rightRow)

val asOfSatisfied = boundAsOfCond.eval(joinedRow)
if (asOfSatisfied != null && asOfSatisfied.asInstanceOf[Boolean]) {
Expand Down