You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is PR 1 of the split from #6009. It migrates the sync-execution backend and agent-service internals to the new execution summary contract while keeping the current frontend response shape compatible.
Core changes:
Replace the sync-execution result model with WorkflowExecutionSummary, OperatorExecutionSummary, and OperatorResultSummary.
Represent sampled rows as [rowIndex, Tuple] pairs instead of embedding row metadata into JSON result records.
Reuse the shared WorkflowFatalError shape for execution and compilation-style failures.
Update agent-service execution formatting, result cache, server paths, and tests to consume the new model.
Keep GET /agents/:id/operator-results legacy-compatible through a temporary adapter, so the existing frontend continues to work until the follow-up frontend PR lands.
A follow-up PR will migrate the frontend to consume the new summary shape directly and remove the temporary compatibility adapter.
How was this PR tested?
cd agent-service && bun test src/server.spec.ts src/agent/tools/result-formatting.spec.ts src/agent/tools/tools-utility.spec.ts src/agent/tools/workflow-execution-tools.spec.ts src/agent/workflow-result-state.spec.ts
The command failed before reaching the spec because local JOOQ generation could not authenticate to Postgres, then existing generated Java deprecation warnings hit -Werror during DAO / Compile.
Was this PR authored or co-authored using generative AI tooling?
❌ Patch coverage is 94.35484% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.58%. Comparing base (1677e43) to head (ffaf65b). ⚠️ Report is 18 commits behind head on main.
Compared against main 1b42558 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This is PR 1 of the split from #6009. It migrates the sync-execution backend and agent-service internals to the new execution summary contract while keeping the current frontend response shape compatible.
Core changes:
WorkflowExecutionSummary,OperatorExecutionSummary, andOperatorResultSummary.[rowIndex, Tuple]pairs instead of embedding row metadata into JSON result records.WorkflowFatalErrorshape for execution and compilation-style failures.GET /agents/:id/operator-resultslegacy-compatible through a temporary adapter, so the existing frontend continues to work until the follow-up frontend PR lands.Main review files:
amber/src/main/scala/org/apache/texera/web/resource/SyncExecutionResource.scalaagent-service/src/types/execution.tsagent-service/src/server.tsAny related issues, documentation, discussions?
Part of #5750.
Part of #5747.
Split from #6009.
A follow-up PR will migrate the frontend to consume the new summary shape directly and remove the temporary compatibility adapter.
How was this PR tested?
cd agent-service && bun test src/server.spec.ts src/agent/tools/result-formatting.spec.ts src/agent/tools/tools-utility.spec.ts src/agent/tools/workflow-execution-tools.spec.ts src/agent/workflow-result-state.spec.tscd agent-service && bun run format:checkcd agent-service && bun run typechecksbt scalafmtCheckAllAttempted but did not complete locally:
sbt "WorkflowExecutionService / testOnly org.apache.texera.web.resource.SyncExecutionResourceSpec"The command failed before reaching the spec because local JOOQ generation could not authenticate to Postgres, then existing generated Java deprecation warnings hit
-WerrorduringDAO / Compile.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Codex