guard against integer overflow in write()#1443
Open
jmestwa-coder wants to merge 1 commit intoapache:masterfrom
Open
guard against integer overflow in write()#1443jmestwa-coder wants to merge 1 commit intoapache:masterfrom
jmestwa-coder wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a guard in ByteArrayOutputStream.write(...) to prevent integer overflow when calculating the new size.
Problem
The size is tracked using an int . When total data exceeds Integer.MAX_VALUE, count + len overflows and becomes negative.Since Wicket uses multiple buffers, this can happen without hitting JVM array limits.
Impact
size() may return a negative value
toByteArray() can throw NegativeArraySizeException
Leads to inconsistent behavior and possible data loss
Fix
Add a simple overflow check and fail fast with IndexOutOfBoundsException.
Notes
No change for valid inputs
No API changes
Minimal, safe fix