Skip to content

feat(identity): validate GitHub OIDC assertions - #203

Merged
aparragithub merged 1 commit into
mainfrom
feat/github-oidc-jose
Aug 10, 2026
Merged

feat(identity): validate GitHub OIDC assertions#203
aparragithub merged 1 commit into
mainfrom
feat/github-oidc-jose

Conversation

@aparragithub

Copy link
Copy Markdown
Owner

Closes #200

Type

  • Bug fix
  • New feature
  • Documentation only
  • Code refactoring
  • Maintenance/tooling
  • Breaking change

Summary

  • Validate compact GitHub OIDC assertions using bounded RS256 and JWKS rules.
  • Enforce issuer, audience, subject, expiry, signature, key, and required-string-claim boundaries.
  • Prove unsupported tenant, role, account, and project claims are never mapped into neutral identity semantics.

Changes

File Change
src/odoo_forge_identity_github/provider.py Private JOSE/JWKS/signature and claim validation
tests/identity_github/test_jose.py Generated-RSA acceptance and rejection matrix

Test plan

  • Adapter suite — 52 passed
  • Full pytest — 1977 passed, 46 deselected
  • Portfolio integrity — 134 passed
  • Ruff lint/format, mypy, and import-linter passed

Chain context

Strategy: stacked to main.

main → PR 1 transport ✅ → PR 2 provider ✅ → 📍 PR 3 JOSE validation

This PR starts from the merged stateless provider and completes the accepted GitHub OIDC validation boundary. Other providers, live network interoperability, session management, provisioning, linking, tenancy mapping, and RBAC remain out of scope. Rollback removes this commit or the complete adapter package and tests.

Contributor checklist

  • Linked approved issue
  • Added exactly one type:* label
  • Applicable checks passed
  • Tests remain with implementation
  • Conventional commit format
  • No AI attribution or co-author trailer

@aparragithub aparragithub added the type:feature New feature label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aparragithub, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f017169b-ffde-4498-81bd-5f9f8205b21e

📥 Commits

Reviewing files that changed from the base of the PR and between 8ad664e and fab3a11.

📒 Files selected for processing (2)
  • src/odoo_forge_identity_github/provider.py
  • tests/identity_github/test_jose.py

Comment @coderabbitai help to get the list of available commands.

@aparragithub
aparragithub merged commit e20f40d into main Aug 10, 2026
6 checks passed
@aparragithub
aparragithub deleted the feat/github-oidc-jose branch August 10, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate GitHub OIDC assertions with RS256 and JWKS

1 participant