fix(ui): preserve dashboard outside manifest scope

[aparragithub]

Closes #190

Summary

• keep the read-only reconciliation dashboard available outside the configured manifest scope
• omit the optional manifest panel without loading manifest data
• preserve API manifest scope isolation

Type

• Bug fix
• New feature
• Documentation only
• Code refactoring
• Maintenance/tooling
• Breaking change

Changes

File	Change
src/odoo_forge_server/views.py	Treat manifest scope as an optional SSR panel condition
tests/odoo_forge_server/test_ui.py	Cover non-manifest project dashboard reconciliation

Test Plan

• Focused UI and API tests pass
• Ruff lint and format checks pass
• Mypy passes for changed files
• Independent candidate verification passes
• RDD receipt approved for the exact candidate

Contributor Checklist

• Linked an issue
• Added the repository bug-fix label
• Shellcheck not applicable: no shell scripts changed
• Applicable workflow skills loaded
• Documentation not required for this bounded regression fix
• Conventional commit format used
• No Co-Authored-By trailers

Summary by CodeRabbit

• Bug Fixes
  • Dashboard requests for projects outside the configured manifest scope no longer return an error.
  • The manifest panel is now omitted when the requested project is outside the configured scope.
  • Reconciliation continues to run normally in this scenario.

[coderabbitai]

Warning

Review limit reached

@aparragithub, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 938e4b5d-7737-450f-b966-fe960927deea

📥 Commits

Reviewing files that changed from the base of the PR and between a0fe6dc and 8796863.

📒 Files selected for processing (1)

• tests/odoo_forge_server/test_ui.py

📝 Walkthrough

Walkthrough

The dashboard now skips manifest loading when the requested scope differs from manifest_scope. It no longer returns 404 for this case. A regression test verifies that reconciliation still runs and the manifest panel is absent.

Changes

Manifest Scope Dashboard

Layer / File(s)	Summary
Scope-aware dashboard behavior src/odoo_forge_server/views.py, tests/odoo_forge_server/test_ui.py	The dashboard loads the manifest only when scopes match. The test verifies a successful response, one reconciliation call, and no manifest loading for an out-of-scope request.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• aparragithub/odoo-forge#191: Introduced the manifest scope-mismatch handling refined by this change.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes preserve the reconciliation dashboard, omit the manifest panel for mismatched scopes, avoid manifest loading, and add regression coverage for issue #190.
Out of Scope Changes check	✅ Passed	The changes are limited to SSR optional-panel behavior and regression coverage, with no unrelated scope expansion or mutation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main UI fix: preserving the dashboard when the requested project is outside the configured manifest scope.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/issue-190-dashboard-scope

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/odoo_forge_server/test_ui.py`:
- Around line 218-235: Update the test around _FakeReconciler and the GET
request to return a distinctive reconciliation row instead of
ReconciliationOutcome.EMPTY, then assert that row is rendered in response.text.
Keep the existing 200 status and manifest-panel assertions, and remove the
reconciler.list_calls implementation-detail assertion.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d99d6359-08ac-490d-bf79-1a1a4d727522

📥 Commits

Reviewing files that changed from the base of the PR and between e20f40d and a0fe6dc.

📒 Files selected for processing (2)

• src/odoo_forge_server/views.py
• tests/odoo_forge_server/test_ui.py