docs(semantic): drop stale references to a gateway-added classifier option - #1261
Merged
Merged
Conversation
…ption The classifier's choice criteria are exactly the configured routes and no route name is reserved; two comments still described the removed gateway-added option and a refusal of a same-named route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two comments still described the classifier option that was removed before #1257 merged: the gateway adds no option of its own, so the
choicecriteria sent to the decision model are exactly the configured routes, and an operator who wants a catch-all configures one as an ordinary route.split_semantic_modesincrates/aisix-core/src/models/schema.rssaid a route named after the gateway-added option was refused; the code never refuses any route name, so the comment now says no name is reserved. The module doc incrates/aisix-core/src/models/semantic.rssaid the decision model picks one route "(or none of them)"; it now says it picks one of the configured routes (a low-confidence pick still falls back todefault, as theSemanticClassifierdocs already state).I swept the rest of the repo — code comments, schema descriptions,
schemas/, config examples, and e2e test names — for any other mention of the removed option or a reserved route name and found none. Both edits are non-doc comments, sodump-schemaproduces no change inschemas/. Comment-only, no behavior change, so no test is added.🤖 Generated with Claude Code