Repository navigation
fix: allow max_retries=0 to disable retries - #1142
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1142 +/- ##
==========================================
+ Coverage 95.43% 95.50% +0.06%
==========================================
Files 61 61
Lines 5935 5937 +2
==========================================
+ Hits 5664 5670 +6
+ Misses 271 267 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 16, 2026 11:26
vdusek
requested review from
Mantisus and
Pijukatel
and removed request for
szaganek
October 16, 2026 11:26
Pijukatel
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_retriescounts retries, so0should mean a single attempt. Instead, every request withmax_retries=0raisedValueErrorfrom the retry loop. Now0disables retries, and a negative value raisesValueErrorwhenApifyClient,ApifyClientAsyncor an HTTP client is constructed.This is a regression from 3.0.0. Up to 2.5.1,
max_retries=0made exactly one attempt; theValueErrorcheck came in with #604. The JS client also accepts0.The tests in
test_client_errors.pythat meant to avoid retries usedmax_retries=1, which still retries once. They now use0.Closes: #1139
✍️ Drafted by Claude Code