Skip to content

fix: fetch the Actor from the API root in get_streamed_log() on last_run() clients - #1143

Merged
vdusek merged 1 commit into
masterfrom
fix/streamed-log-last-run-url
Oct 16, 2026
Merged

vdusek merged 1 commit into
masterfrom
fix/streamed-log-last-run-url

Conversation

@vdusek

@vdusek vdusek commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

get_streamed_log() and get_status_message_watcher() built the Actor client from the run client's _base_url. On actor(...).last_run() or task(...).last_run() that is the parent's URL, so the Actor lookup hit /v2/acts/<X>/acts/<actId>, got a 404, and the logger name had no Actor name. They now use the API root, like iterate_dataset_items().

Closes: #1137

✍️ Drafted by Claude Code

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 16, 2026
@vdusek vdusek self-assigned this Oct 16, 2026
@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.46%. Comparing base (53a9954) to head (6a0e950).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
+ Coverage   95.43%   95.46%   +0.03%     
==========================================
  Files          61       61              
  Lines        5935     5935              
==========================================
+ Hits         5664     5666       +2     
+ Misses        271      269       -2     
Flag Coverage Δ
integration 90.95% <ø> (+0.15%) ⬆️
unit 88.91% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review October 16, 2026 11:27
@vdusek
vdusek requested review from Mantisus and Pijukatel October 16, 2026 11:27
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Oct 16, 2026
@vdusek
vdusek merged commit 2b58a2b into master Oct 16, 2026
37 of 38 checks passed
@vdusek
vdusek deleted the fix/streamed-log-last-run-url branch October 16, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_streamed_log() on a last_run() client requests the Actor from a wrong URL

3 participants