Repository navigation
chore: align named child runs with the JS SDK - #1184
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1184 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 54 54
Lines 3671 3672 +1
=======================================
+ Hits 3416 3417 +1
Misses 255 255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 15, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1149 and #1151 that aligns named child runs with the final version of apify/apify-sdk-js#759.
Changes:
run_nameraises aValueErroronly when the recorded run would be reused (reattached, returned asSUCCEEDED, or resurrected). When the recorded runFAILEDor is gone, a new run starts with the new request, the old run moves tohistory, and the record takes the new checksum (agreed here).run_namedocstrings describe the new rule.No action on B4nan's comment about loading the child-run record lazily instead of in Actor init. JS kept the load in
init(), because the synchronousActor.childRunsgetter needs the records, and Python already loads them the same way in__aenter__.The docs in #1160 still say a name is bound to its first input. That will be fixed there.
✍️ Drafted by Claude Code