Skip to content

chore: align named child runs with the JS SDK - #1184

Merged
vdusek merged 4 commits into
masterfrom
feat/child-runs-replace-input
Oct 15, 2026
Merged

vdusek merged 4 commits into
masterfrom
feat/child-runs-replace-input

Conversation

@vdusek

@vdusek vdusek commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #1149 and #1151 that aligns named child runs with the final version of apify/apify-sdk-js#759.

Changes:

  • A different Actor, task or input under an existing run_name raises a ValueError only when the recorded run would be reused (reattached, returned as SUCCEEDED, or resurrected). When the recorded run FAILED or is gone, a new run starts with the new request, the old run moves to history, and the record takes the new checksum (agreed here).
  • The client of a named run is stored only after the run is started or reused.
  • The run_name docstrings describe the new rule.

No action on B4nan's comment about loading the child-run record lazily instead of in Actor init. JS kept the load in init(), because the synchronous Actor.childRuns getter needs the records, and Python already loads them the same way in __aenter__.

The docs in #1160 still say a name is bound to its first input. That will be fixed there.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 15, 2026
@vdusek vdusek self-assigned this Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.05%. Comparing base (3ed1a48) to head (a0f4ece).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1184   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files          54       54           
  Lines        3671     3672    +1     
=======================================
+ Hits         3416     3417    +1     
  Misses        255      255           
Flag Coverage Δ
e2e 31.72% <20.00%> (-0.01%) ⬇️
integration 51.68% <20.00%> (-0.02%) ⬇️
unit 89.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek changed the title feat: allow a different input when a named child run is replaced chore: align named child runs with the JS SDK Oct 15, 2026
@vdusek
vdusek requested review from Mantisus and barjin October 15, 2026 10:05
@vdusek
vdusek marked this pull request as ready for review October 15, 2026 10:05
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Oct 15, 2026

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a small nit regarding the docs (resolve at your discretion).

Thanks @vdusek !

Comment thread src/apify/_actor.py Outdated
@vdusek
vdusek merged commit 290af90 into master Oct 15, 2026
31 checks passed
@vdusek
vdusek deleted the feat/child-runs-replace-input branch October 15, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants