Repository navigation
fix: deprecate exit_code and status_message in the Actor constructor - #1194
Open
cobanfurkanx wants to merge 1 commit into
Open
cobanfurkanx wants to merge 1 commit into
cobanfurkanx wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
t-tooling
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
exit_codeorstatus_messagetoActor(...)now emits aDeprecationWarning(scheduled for removal in 5.0.0) recommendingActor.exit()/Actor.fail()or settingActor.exit_code/Actor.status_messageinside the context manager.Default values in
_ActorType.__init__and_ActorType.__call__are changed toNoneso an explicitActor(exit_code=0)also triggers the warning while bareActor()continues to default_exit_codeto0without warning.Closes: #1186