Repository navigation
fix(python): keep a custom Content-Type when sending form data - #583
Merged
Merged
Conversation
barjin
approved these changes
Oct 19, 2026
barjin
left a comment
Member
There was a problem hiding this comment.
lgtm, thank you @RaphaelFakhri!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you pass a
dicttodata=, the Python client setsContent-Type: application/x-www-form-urlencodedon the request. It does this unconditionally, so aContent-Typeheader you pass inheaders=gets replaced, for exampleapplication/x-www-form-urlencoded; charset=utf-8. If your header key uses a different case, such ascontent-type, both entries end up in the request header map, and which one is sent depends on the hash map iteration order.This change adds the default
Content-Typeonly when the request headers don't already contain one (compared case-insensitively). This matcheshttpx, where an explicitContent-Typetakes precedence over the one derived fromdata=.Changes
impit-python/src/request.rs: into_body, skip the default formContent-Typeif the caller already set the header.impit-python/test/basic_client_test.py,impit-python/test/async_client_test.py: addtest_form_keeps_custom_content_type. The tests send a form with a customContent-Typeto the local echoing server and check the header that arrives.Testing
content-type: application/x-www-form-urlencodedwithout thecharsetparameter.Fixes #582