Repository navigation
Conversation
Collection::Gem#without_yard globbed only the gem's require_paths, so
code that Rails engines keep under app/ went unmapped once gems stopped
going through YARD, whose default source glob is {lib,app}/**/*.rb.
turbo-rails defines Turbo::Broadcastable in app/models/concerns, so
broadcast_* methods vanished from ActiveRecord::Base.
Add app/ to the mapped paths. Gems without an app/ directory map the
same pins as before.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
Owner
Author
|
Claude: Closing in favor of the convention-hook approach: castwide#1404, castwide#1407 and iftheshoefritz/solargraph-rails#228. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Problem
Methods from a Rails engine's
app/directory are not found:This affects every engine that keeps code under
app/, including turbo-rails, activestorage, actionmailbox, solid_queue and devise.Solution
Collection::Gem#without_yardnow parsesapp/**/*.rbalongside the gem's require paths, matching the{lib,app}/**/*.rbfiles YARD read before castwide#1378, without the plugin hook of castwide#1404 and castwide#1407.YARD's
ext/glob is not included.