Repository navigation
Conversation
This reverts commit 7a16244 (castwide#1469). Plugin::ActiveSupport does not replace the convention. The convention's object hook adds class-scope methods of any included module that extends ActiveSupport::Concern, including gem pins (the class_methods bodies yard-activesupport-concern maps, e.g. has_one_attached), plus the module's ClassMethods instance methods, recursively (ActiveJob::Base gets ActiveSupport::Callbacks::ClassMethods via ActiveJob::Callbacks). Without it the solargraph-rails specs went from 1 failure to 6: devise_spec:4, rails_spec:122/132/152/158 (define_callbacks, set_callback, skip_callback not found) and storage_spec:4 (attach). The convention.rb conflict keeps castwide#1468's autoload list and re-adds the ActiveSupportConcern autoload and register lines.
Style/SelectByKind flags the restored select/is_a? lookup in Convention::ActiveSupportConcern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Problem
Methods Rails adds through concerns no longer complete:
solargraph-rails specs went from 1 failure to 6 (devise_spec:4, rails_spec:122/132/152/158, storage_spec:4);
continue-on-errorin plugins.yml hides it.Solution
Restore
Convention::ActiveSupportConcern, which castwide/solargraph#1469, Remove Convention::ActiveSupportConcern removed:Plugin::ActiveSupportdoes not cover itsobjecthook, which adds the class-scope methods of any included module that extendsActiveSupport::Concern(gem pins included) plus itsClassMethodsmodule's methods, recursively.