Skip to content

test: cover user-token deletes for plain and encoded keys - #7

Merged
nobodyiam merged 1 commit into
mainfrom
codex/fix-user-token-encoded-delete
Sep 20, 2026
Merged

nobodyiam merged 1 commit into
mainfrom
codex/fix-user-token-encoded-delete

Conversation

@nobodyiam

Copy link
Copy Markdown
Member

config delete uses the encoded-items endpoint for keys containing / or \, but the existing deletion coverage only exercised consumer tokens with an operator. Add user-token regression coverage for ordinary, slash, and backslash keys.

The test checks the DELETE method, the exact plain or Base64URL-encoded path without an operator query parameter, Bearer authentication, and the reported operation target.

Validation:

  • cargo fmt --check
  • bash -n scripts/mutation-smoke.sh
  • cargo clippy --locked --offline --all-targets --all-features -- -D warnings
  • cargo test --locked --offline — 180 tests passed
  • git diff --check

Copilot AI lite review requested due to automatic review settings September 20, 2026 10:04
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a82b653f-f629-4551-a5d9-7343291772a6


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-20T10:05:36.766186Z ee238c4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change is isolated to test coverage and the new assertions precisely validate the intended request behavior without introducing production-code risk.

Review effort: Lite
Findings: None

What changed in this PR

Adds regression coverage ensuring config delete uses the correct OpenAPI delete endpoint (items/* vs encodedItems/*) and request shape when authenticating with a user token, specifically for keys that are plain, contain /, or contain \, and ensuring no operator query parameter is included.

Changes:

  • Add a new test that iterates over plain/slash/backslash keys and validates DELETE method, exact request path (plain vs Base64URL-encoded), and Bearer auth header.
  • Assert the reported operation target in JSON output matches config.delete and preserves the original key string.
File Description
tests/​openapi.rs Adds a user-token-focused regression test validating config delete behavior for plain and path-sensitive keys without an operator parameter.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nobodyiam
nobodyiam merged commit 0f88b26 into main Sep 20, 2026
4 checks passed
@nobodyiam
nobodyiam deleted the codex/fix-user-token-encoded-delete branch September 20, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants