Repository navigation
docs: update Docker quick start readiness logs - #5689
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f201405bdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| > If you are using a machine with an ARM architecture, such as a Mac M1, execute `docker-compose -f docker-compose-arm64.yml up` | ||
|
|
||
| Search all the logs starting with `apollo-quick-start` and see the following logs indicating a successful start. | ||
| Quick Start images for Apollo 3.0.0 and later run one foreground Java process containing Config Service, Admin Service, and Portal. Application logs are written to both the console and `/apollo-quick-start/apollo-service.log` by default. |
There was a problem hiding this comment.
Align the guide with the published Quick Start image
When this documentation lands before the companion image update, the preceding download steps still pull the untagged nobodyiam/apollo-quick-start, whose published latest tag is currently 2.5.0. That image's startup configuration unconditionally sets LOG_APPENDERS=FILE, and its Dockerfile launches demo.sh, so it does not emit these three markers to docker logs or honor the compose override described below. Users following the guide will therefore wait for output that cannot appear; publish and pin the compatible 3.0 image before replacing the existing readiness instructions, or retain instructions for the currently published image.
Useful? React with 👍 / 👎.
What's the purpose of this PR
The Docker Quick Start guide still shows the old background launcher's service/portal messages and separate log directories. Apollo 3.0.0 runs all three services in a foreground Java process, so these instructions no longer identify successful startup.
Update both language guides with the actual Config/Admin/Portal
isActive: truemessages and the shared/apollo-quick-start/apollo-service.logpath. apolloconfig/apollo-quick-start#129 enables console application logs by default.Which issue(s) this PR fixes
No linked issue.
Brief changelog
Validation: checked both guides against actual Apollo 3.0.0 + MySQL 8.0 container logs and HTTP startup;
git diff --checkand./mvnw -q spotless:applypassed. Java code is unchanged, so Maven unit tests were not rerun.mvn clean test): not run for this documentation-only change.mvn spotless:apply.Summary by CodeRabbit
isActive: truemessages for Config, Admin, and Portal as startup completion indicators, and clarify when to openhttp://localhost:8070./apollo-quick-start/apollo-service.logand explained how to inspect the file from a shell inside the container.