Add Apple container sentinel file#1779
Open
culpen90 wants to merge 2 commits into
Open
Conversation
Contributor
|
@culpen90 Thank you for the enhancement! Have a look at the comment from Anders at the bottom of the issue: #140 (comment). Can you implement the container sentinel using an env file instead? Ideally this change could be limited to just the RuntimeService. |
82c5f99 to
f5ff2fb
Compare
Author
|
Thanks, updated this to use an env file sentinel instead. The runtime now writes Validated locally with: swift build --target ContainerRuntimeLinuxServer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes #140.
This adds a read-only
/run/.containerenvsentinel file for Linux containers so applications have a reliable Apple container detection signal without changing the process environment.Testing
swift build --target ContainerRuntimeLinuxServer