Skip to content

xpc: replace precondition+force-unwrap with guard-let in XPCMessage #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArasanDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

xpc: replace precondition+force-unwrap with guard-let in XPCMessage #1852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Sources/ContainerXPC/XPCMessage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ extension XPCMessage {
public func error() throws {
let data = data(key: Self.errorKey)
if let data {
let item = try? JSONDecoder().decode(ContainerXPCError.self, from: data)
precondition(item != nil, "expected to receive a ContainerXPCXPCError")

throw ContainerizationError(item!.code, message: item!.message)
guard let item = try? JSONDecoder().decode(ContainerXPCError.self, from: data) else {
preconditionFailure("expected to receive a ContainerXPCError")
}
throw ContainerizationError(item.code, message: item.message)
}
}

Expand All @@ -91,10 +91,10 @@ extension XPCMessage {
message += " (cause: \"\(cause)\")"
}
let serializableError = ContainerXPCError(code: error.code.description, message: message)
let data = try? JSONEncoder().encode(serializableError)
precondition(data != nil)

set(key: Self.errorKey, value: data!)
guard let data = try? JSONEncoder().encode(serializableError) else {
preconditionFailure("failed to encode ContainerXPCError")
}
set(key: Self.errorKey, value: data)
}
}

Expand Down