Add checksum validation to hawkeye installation#1869
Open
katiewasnothere wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Hawkeye is used to ensure files in this repository contain the correct licensing information. Hawkeye is used both by developers when preparing a pull request and by our CI workflows as a gate check for pull request approval.
This PR changes our Hawkeye installation script away from that provided in the Hawkeye release to one that validates the checksum of the downloaded release archive. This PR will break existing anyone using the
scripts/install-hawkeye.shscript to install Hawkeye on architectures other than Apple Silicon. Since Apple Silicon is required for building this repository, I do not consider this a breaking change.Testing