Added known HTTP header field names from W3C Trace Context - #124
Merged
guoye-zhang merged 2 commits intoJun 1, 2026
Merged
Conversation
These headers are defined by W3C Trace Context (https://www.w3.org/TR/trace-context/) and are used by OpenTelemetry and other distributed tracing systems. Resolves apple#101.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds W3C Trace Context HTTP header field-name conveniences to HTTPField.Name to support distributed tracing interoperability.
Changes:
- Introduces
HTTPField.Name.traceparentconstant. - Introduces
HTTPField.Name.tracestateconstant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// Traceparent | ||
| /// | ||
| /// https://www.w3.org/TR/trace-context/ | ||
| public static var traceparent: Self { .init(rawName: "Traceparent", canonicalName: "traceparent") } |
| /// Tracestate | ||
| /// | ||
| /// https://www.w3.org/TR/trace-context/ | ||
| public static var tracestate: Self { .init(rawName: "Tracestate", canonicalName: "tracestate") } |
FranzBusch
reviewed
May 27, 2026
FranzBusch
left a comment
FranzBusch
left a comment
Member
There was a problem hiding this comment.
@guoye-zhang What do you think of adding those headers?
guoye-zhang
approved these changes
May 27, 2026
Contributor
|
Looks fine, let’s add it if it’s useful to open telemetry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these headers are defined by W3C Trace Context and are used by OpenTelemetry and other distributed tracing systems.
resolves #101.