Skip to content

Add project variable migration wizard support#3044

Open
premtsd-code wants to merge 1 commit into
add-api-key-migrationfrom
add-project-variable-migration
Open

Add project variable migration wizard support#3044
premtsd-code wants to merge 1 commit into
add-api-key-migrationfrom
add-project-variable-migration

Conversation

@premtsd-code
Copy link
Copy Markdown
Contributor

Summary

Stacks on the api-key console PR. Adds project-variable as its own top-level group in the migration wizard, parallel to platforms and api-keys.

Cross-repo

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 14, 2026

Greptile Summary

This PR adds project-variable as a new top-level migration resource group (settings) in the wizard, parallel to platforms and api-keys, covering the store type declarations, form↔resource conversion logic, rendering guards, and label/description maps.

  • migration.ts extends MigrationResource, MigrationResources, ResourcesFriendly, providerResources.appwrite, and both migrationFormToResources/resourcesToMigrationForm with the new project-variable entry, following the same patterns used for api-key and platform.
  • resource-form.svelte adds a settings branch to shouldRenderGroup and a settings → 'project-variable' entry to getReportKey, keeping display logic consistent with other groups.
  • importReport.svelte registers settings in labelMap and descriptionMap; because the group has no child keys, the component takes the simple-checkbox path where only the label is shown and the descriptionMap entry goes unused (the same dead-code pattern exists for backups and storage).

Confidence Score: 5/5

Safe to merge — the change is additive and follows established patterns already used for platform and api-key.

All three files introduce project-variable / settings by mirroring the exact patterns used for the prior api-key and platform additions. The form-to-resource and resource-to-form round-trip is correctly implemented, the render guard is consistent, and no existing paths are modified.

No files require special attention.

Important Files Changed

Filename Overview
src/lib/stores/migration.ts Adds project-variable to the MigrationResource type, MigrationResources enum, ResourcesFriendly, providerResources (appwrite only), and both form↔resource conversion functions; follows the same pattern as api-key and platform
src/routes/(console)/(migration-wizard)/resource-form.svelte Adds a settings guard to shouldRenderGroup and a settings → 'project-variable' mapping in getReportKey; consistent with existing group handling
src/routes/(console)/project-[region]-[project]/settings/migrations/(import)/importReport.svelte Adds settings entries to labelMap and descriptionMap; description text is not surfaced to users through the current rendering path (no-children simple-checkbox branch), which is a pre-existing pattern also affecting backups and storage

Reviews (2): Last reviewed commit: "Add project variable migration wizard su..." | Re-trigger Greptile

Adds new 'settings' form group (parent for project-level configuration
like variables and webhooks). Project variables become settings.root.
The backend migration library exposes them via the new GROUP_SETTINGS.
@premtsd-code premtsd-code force-pushed the add-project-variable-migration branch from 4477797 to e53bbac Compare May 14, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant