Skip to content

fix(sites): generate mobile QR through console project - #3176

Merged
ChiragAgg5k merged 1 commit into
mainfrom
fix-sites-qr-disabled-avatars
Aug 20, 2026
Merged

fix(sites): generate mobile QR through console project#3176
ChiragAgg5k merged 1 commit into
mainfrom
fix-sites-qr-disabled-avatars

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

Summary

  • generate the Sites "Open on mobile" QR code through the regional console project
  • keep QR rendering independent of the selected project's Avatars service setting

Problem

The modal currently calls avatars.getQR() with the selected project. If that project has Avatars disabled, the image request returns 403 general_service_disabled and the modal shows a broken QR image even though Sites is enabled.

The QR code is a Console UI asset rather than a project Avatars operation, so it should use the console project, consistent with other Console-owned QR generation.

Validation

  • bun run format
  • bun run check
  • bun run lint (passes with existing warnings)
  • bun run test:unit (265 tests)
  • bun run build

@appwrite

appwrite Bot commented Aug 20, 2026

Copy link
Copy Markdown

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

SSR frameworks are fully supported with configurable build runtimes

@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR routes the Sites “Open on mobile” QR request through the regional console project so QR rendering no longer depends on whether Avatars is enabled for the selected project.

  • Replaces the project-scoped SDK client with the region-scoped console client.
  • Keeps the existing QR payload and dimensions unchanged.

Confidence Score: 5/5

The PR appears safe to merge because it uses the established console-scoped QR generation pattern while preserving regional endpoint selection.

The changed call isolates this Console-owned image from the selected project’s Avatars service setting without altering the encoded URL or rendering flow.

Important Files Changed

Filename Overview
src/routes/(console)/project-[region]-[project]/sites/(components)/openOnMobileModal.svelte Switches QR generation from the selected project’s Avatars service to the regional console project; no actionable defect was identified.

Reviews (1): Last reviewed commit: "fix(sites): generate mobile QR through c..." | Re-trigger Greptile

@ChiragAgg5k
ChiragAgg5k merged commit e358104 into main Aug 20, 2026
4 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the fix-sites-qr-disabled-avatars branch August 20, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants