Skip to content

fix(storage): correct allowed file extensions input copy - #3179

Open
cursor[bot] wants to merge 4 commits into
mainfrom
fix-1018-allowed-extensions-labels-copy
Open

fix(storage): correct allowed file extensions input copy#3179
cursor[bot] wants to merge 4 commits into
mainfrom
fix-1018-allowed-extensions-labels-copy

Conversation

@cursor

@cursor cursor Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The Storage → Bucket → Settings Allowed file extensions field was still using Labels UI copy (id="user-labels", label Labels, placeholder Select or type user labels).

This updates the field to extension-specific wording and clears the placeholder once extensions are selected so it does not remain visible next to chips (fixes #1018).

Test Plan

  1. Open a bucket’s Settings tab.
  2. Confirm the extensions input shows label File extensions and placeholder Allowed file extensions (mp4, jpg, pdf, etc.) when empty.
  3. Add an extension (chip or suggested tag) and confirm the placeholder is gone.
  4. Save and reload; existing extensions still load correctly.

Related PRs and Issues

Open in Web View Automation 

The bucket settings Allowed file extensions field reused Labels copy
(id, label, and placeholder). Use extension-specific wording and clear
the placeholder once tags are present so it does not sit beside chips.

Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
@appwrite

appwrite Bot commented Aug 23, 2026

Copy link
Copy Markdown

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Function builds can take up to 45 minutes before timing out

@cursor
cursor Bot requested a review from ChiragAgg5k August 23, 2026 03:38
@cursor
cursor Bot marked this pull request as ready for review August 23, 2026 03:38
@greptile-apps

greptile-apps Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR corrects the copy for the bucket allowed-file-extensions input.

  • Renames the field and identifier to describe file extensions.
  • Shows extension-specific guidance while the list is empty and clears it after an extension is selected.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/routes/(console)/project-[region]-[project]/storage/bucket-[bucket]/settings/+page.svelte Updates the allowed-extension field’s identifier, label, and placeholder without changing its persisted extension state or save behavior.

Reviews (4): Last reviewed commit: "chore: retrigger flaky onboarding e2e (3..." | Re-trigger Greptile

cursoragent and others added 3 commits August 23, 2026 03:58
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Co-authored-by: chiragaggarwal5k <chiragaggarwal5k@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Placeholder Shown in the Allowed File Extensions Input

1 participant