Repository navigation
feat: SDK update for version 8.1.0 - #104
Conversation
Adds the optional state parameter to createOAuth2Token (appwrite/appwrite#14157).
🔵 Tier A · Mergeable after minor fixes
Adds an optional
Fix with agent prompt### Issue 1
Appwrite/Services/Account.cs:1943
**Encode state as a query parameter value**
This goes through `Client.PrepareRequest` and `Extensions.ToQueryString`, which escapes the assembled URI rather than individual values, leaving `+`, `&`, and `#` unescaped. A state such as `a+b` (common with base64 tokens) arrives as `a b`, while `a&b` is split into parameters, so it cannot be returned unchanged; encode query values individually before assembling the URL.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 6
Reviewed |
| { "failure", failure }, | ||
| { "scopes", scopes } | ||
| { "scopes", scopes }, | ||
| { "state", state } |
There was a problem hiding this comment.
Encode state as a query parameter value
This goes through Client.PrepareRequest and Extensions.ToQueryString, which escapes the assembled URI rather than individual values, leaving +, &, and # unescaped. A state such as a+b (common with base64 tokens) arrives as a b, while a&b is split into parameters, so it cannot be returned unchanged; encode query values individually before assembling the URL.
Prompt To Fix With AI
This is a comment left during a code review.
Path: Appwrite/Services/Account.cs
Line: 1943
Comment:
**Encode state as a query parameter value**
This goes through `Client.PrepareRequest` and `Extensions.ToQueryString`, which escapes the assembled URI rather than individual values, leaving `+`, `&`, and `#` unescaped. A state such as `a+b` (common with base64 tokens) arrives as `a b`, while `a&b` is split into parameters, so it cannot be returned unchanged; encode query values individually before assembling the URL.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
This PR contains updates to the SDK for version 8.1.0.
What's Changed
stateparameter oncreateOAuth2Token, returned unchanged on the success and failure URLsThis is a patch on top of the previous stable release: it adds only the
stateparameter from appwrite/appwrite#14157, plus the version bump and changelog. Generated by diffing the sdk-generator output for the specs before and after #14157.