Repository navigation
feat: SDK update for version 28.2.0 - #346
Conversation
🔵 Tier A · Mergeable after minor fixes
Updates the Flutter SDK to version 28.2.0 and targets Appwrite 2.6.x. Service path parameters are encoded as individual segments, and optional parameters in examples and service tests are exercised with explicit values. 10 of 42 changed files were too large to include in full.
Note Part of the diff was too large to review, so Hansi did not approve.
Fix with agent prompt### Issue 1
lib/appwrite.dart:66
**Add coverage for slash and dot-segment IDs**
The service path tests use angle-bracket IDs, but none exercise an ID containing `/` or the exact `.` and `..` cases. Those are the key cases for verifying that IDs remain one path segment and that dot-segment IDs are rejected, so a regression in this new helper could pass the current tests.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 5
Reviewed |
|
@hansi-codes review |
| if (value == '.' || value == '..') { | ||
| throw AppwriteException('Path parameter cannot be "." or ".."'); | ||
| } | ||
| return Uri.encodeComponent(value); |
There was a problem hiding this comment.
Add coverage for slash and dot-segment IDs
The service path tests use angle-bracket IDs, but none exercise an ID containing / or the exact . and .. cases. Those are the key cases for verifying that IDs remain one path segment and that dot-segment IDs are rejected, so a regression in this new helper could pass the current tests.
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/appwrite.dart
Line: 66
Comment:
**Add coverage for slash and dot-segment IDs**
The service path tests use angle-bracket IDs, but none exercise an ID containing `/` or the exact `.` and `..` cases. Those are the key cases for verifying that IDs remain one path segment and that dot-segment IDs are rejected, so a regression in this new helper could pass the current tests.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
This PR contains updates to the SDK for version 28.2.0.
What's Changed
X-Appwrite-Response-Format: 2.6.2; the SDK targets Appwrite 2.6.x.and..throwAppwriteExceptionnullfor unset optional params instead of empty strings