Skip to content

feat: Ruby SDK update for version 29.0.0 - #74

Closed
ChiragAgg5k wants to merge 2 commits into
mainfrom
dev
Closed

ChiragAgg5k wants to merge 2 commits into
mainfrom
dev

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the Ruby SDK for version 29.0.0.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

馃數 Tier A 路 Mergeable after minor fixes

The SDK changes appear coherent, but two updated documentation examples fail before making their requests because of invalid Ruby syntax or a non-Ruby literal.

Updates the Ruby SDK to version 29.0.0 and Appwrite response format 2.4.0. It adds passkey, domains, WAF, OAuth, policy, and messaging APIs and models, adjusts client request/response handling, and refreshes generated examples and documentation.

340 of 563 changed files were too large to include in full.

Verdict New comments Fixed Still open
馃挰 Commented 2 0 0

Note

Part of the diff was too large to review, so Hansi did not approve.

Finding Where
馃煛 Fix the Ruby quoting in the mutation example docs/examples/graphql/mutation.md:15
馃煛 Use Ruby nil for the optional period docs/examples/domains/get-price.md:16
Fix with agent prompt
### Issue 1
docs/examples/graphql/mutation.md:15
**Fix the Ruby quoting in the mutation example**

The inner `"Walter"` closes the outer string, so this example has a Ruby syntax error when copied. Use single quotes around the GraphQL document or escape the inner quotes.

### Issue 2
docs/examples/domains/get-price.md:16
**Use Ruby `nil` for the optional period**

Ruby has no `null` literal, so this example raises an error before making the request; use `nil` for the optional `period_years` value. The `domains/list-prices.md` example has the same issue.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
馃搨 Walkthrough 路 6
File Change
CHANGELOG.md, README.md, appwrite.gemspec Document SDK 29.0.0 changes and update the API target and gem version.
lib/appwrite/client.rb Update request headers and add multipart, upload-method, and text-response handling.
lib/appwrite.rb, lib/appwrite/topic.rb, lib/appwrite/enums/** Load new SDK helpers and enums, and remove obsolete enum references.
lib/appwrite/models/** Add and update response models, including defaults for omitted response fields.
lib/appwrite/services/** Add and update service methods for the 29.0 API surface.
docs/examples/** Add examples for new APIs and update existing examples for changed parameters.

Reviewed 21769f2 路 Details 路 Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃數 Tier A 路 See the inline comments. Summary

result = graphql.mutation(
query: {}
query: {
"query" => "mutation { accountUpdateName(name: "Walter") { name } }"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the Ruby quoting in the mutation example

The inner "Walter" closes the outer string, so this example has a Ruby syntax error when copied. Use single quotes around the GraphQL document or escape the inner quotes.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/graphql/mutation.md
Line: 15

Comment:
**Fix the Ruby quoting in the mutation example**

The inner `"Walter"` closes the outer string, so this example has a Ruby syntax error when copied. Use single quotes around the GraphQL document or escape the inner quotes.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

馃煛 Minor 路 documentation 路 Reply if this doesn't apply.


result = domains.get_price(
domain: 'example.com',
period_years: null, # optional

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Ruby nil for the optional period

Ruby has no null literal, so this example raises an error before making the request; use nil for the optional period_years value. The domains/list-prices.md example has the same issue.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/examples/domains/get-price.md
Line: 16

Comment:
**Use Ruby `nil` for the optional period**

Ruby has no `null` literal, so this example raises an error before making the request; use `nil` for the optional `period_years` value. The `domains/list-prices.md` example has the same issue.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

馃煛 Minor 路 documentation 路 Reply if this doesn't apply.

@ChiragAgg5k

Copy link
Copy Markdown
Member Author

Superseded: replaced by a passkeys-only minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant