Repository navigation
feat: SDK update for version 29.1.0 - #192
Conversation
🔵 Tier A · Mergeable after minor fixes
This release adds account membership listing, APNs routing fields for push targets, and POST-based query methods across the database services. It also adds modular and minified CDN builds, updates release documentation and metadata, and refreshes build dependencies.
Fix with agent prompt### Issue 1
src/services/tables-db.ts:518
**Clarify metadata defaults on projected rows**
This promise is not true for SDK return values: `listRows` and the new `createQuery` pass rows through `applyDefaults`, which fills `$id`, `$sequence`, `$createdAt`, and the other listed fields when a projection omits them. Callers inspecting those properties will still see empty defaults, including on unmatched joins, so please distinguish the raw server response from the SDK result.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 18
Reviewed |
| /** | ||
| * Get a list of all the user's rows in a given table. You can use the query params to filter your results. | ||
| * | ||
| * Rows returned by aggregate, groupBy or distinct queries hold only the columns they select, group or aggregate, typed as a row types them, with a joined column named by its join alias (`alias.column`). They have no `$id`, `$sequence`, `$createdAt`, `$updatedAt`, `$permissions`, `$databaseId` or `$tableId` unless they select or group it, and neither does a right or full join row that no row of this table matched. |
There was a problem hiding this comment.
Clarify metadata defaults on projected rows
This promise is not true for SDK return values: listRows and the new createQuery pass rows through applyDefaults, which fills $id, $sequence, $createdAt, and the other listed fields when a projection omits them. Callers inspecting those properties will still see empty defaults, including on unmatched joins, so please distinguish the raw server response from the SDK result.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/services/tables-db.ts
Line: 518
Comment:
**Clarify metadata defaults on projected rows**
This promise is not true for SDK return values: `listRows` and the new `createQuery` pass rows through `applyDefaults`, which fills `$id`, `$sequence`, `$createdAt`, and the other listed fields when a projection omits them. Callers inspecting those properties will still see empty defaults, including on unmatched joins, so please distinguish the raw server response from the SDK result.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · documentation · Reply if this doesn't apply.
This PR contains updates to the SDK for version 29.1.0.
What's Changed
account.listMembershipsto list the current user's team membershipscreateQueryondatabases,tablesDBanddocumentsDBto send list queries in the request bodybundleIdandenvironmentonaccount.createPushTargetto route APNs tokenssdk.appwrite.io/web/<version>/dist/iife/sdk.jsis minified, so CDN script tags load about half the bytes