Repository navigation
fix(codex-plugin): name deploy skills after their directories - #2086
Merged
Merged
Conversation
The Agent Skills spec requires a skill's frontmatter name to match its parent directory. The Codex plugin ships the deploy commands as skills under appwrite-deploy-site and appwrite-deploy-function, but kept the bare command names, so spec-conforming loaders reject or misname them. Claude and Cursor still emit these templates as commands named by file, so their names stay unchanged.
🟢 Tier S · Ready to merge
Updated the shared deploy-site and deploy-function templates to use the skill-name filter for Codex-generated skills while preserving command names for Claude and Cursor. Added generation coverage that checks each generated SKILL.md name against its containing directory across the four skill targets.
📂 Walkthrough · 3
Merged |
2 tasks
…l-names # Conflicts: # tests/generation/GenerationTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Codex plugin emits the shared deploy templates (
templates/plugin/commands/deploy-*.md.twig) as skills atplugins/appwrite/skills/appwrite-deploy-site/SKILL.mdand.../appwrite-deploy-function/SKILL.md, but their frontmatternamewasdeploy-site/deploy-function. The Agent Skills specification requires thenamefield to match the parent directory name.For
CodexPluginthe frontmatter name now goes through the existingskillNamefilter, givingappwrite-deploy-site/appwrite-deploy-function, the same prefix the generated language skills already use.The Claude and Cursor plugins render the same templates as slash commands (
commands/deploy-site.md,commands/deploy-function.md), where the command is named by its file, so their output is unchanged. Every other generatedSKILL.md(skills, Claude, Cursor, Codex language skills) already matched its directory.Test Plan
testSkillNamesMatchTheirDirectorieswith aSKILL_LANGUAGEStable (skills, claude-plugin, cursor-plugin, codex-plugin) asserting every generatedSKILL.mdfrontmatter name equals its directory name.codex-pluginfails with'appwrite-deploy-function'expected,'deploy-function'actual.codex-plugin,claude-plugin,cursor-plugin,skillsandzed-extension; all 46 generatedSKILL.mdfiles match their directories, and the Claude/Cursor commands still readname: deploy-site/name: deploy-function.claude plugin validate examples/claude-pluginpasses.composer lint,composer refactor:check,composer lint-twigand the twig max-line-length check pass.Related PRs and Issues
None.
Closes #2087