Repository navigation
Add WDK memcmp compatibility for legacy 32-bit Windows STL vector resize - #101
Merged
Merged
Conversation
Co-authored-by: SergiusTheBest <4660722+SergiusTheBest@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix resize method for kf::vector on 32-bit systems
Add WDK memcmp compatibility for legacy 32-bit Windows STL vector resize
Aug 14, 2026
Member
|
@copilot Build failed |
Contributor
Author
The failure is the legacy 32-bit Windows STL compatibility issue: older Win XP/7 CRTs do not export the memcmp symbol used by scalar-fill paths in STL. The fix is to link |
SergiusTheBest
requested changes
Aug 14, 2026
Co-authored-by: SergiusTheBest <4660722+SergiusTheBest@users.noreply.github.com>
SergiusTheBest
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The STL implementation used by
kf::vector::resize(count, value)on older 32-bit Windows targets expects amemcmpsymbol that the legacy CRT does not export. This manifests when resizing integer vectors and causes the binary to pull in unsupported legacymemcmpreferences on Windows XP–7.Overview
kf::vectorwraps STL vector behavior and relies on the standard scalar-fill implementation behindresize(..., value).Changes
test/CMakeLists.txt.CMAKE_SIZEOF_VOID_P EQUAL 4, so modern 64-bit builds remain unchanged.